Merged
Conversation
…adog.yml" to deploy.
There was a problem hiding this comment.
comment not needed
git grep -n --color=auto -r datadog_host_address .
delta-hosts/variables:56:datadog_host_address=10.8.5.63
gamma-hosts/variables:55:datadog_host_address=10.4.6.251
group_vars/all.yml:54:datadog_host_address: "{{ ansible_default_ipv4.address }}"
group_vars/alpha-api.yml:24: -e DATADOG_HOST={{ datadog_host_address }}
group_vars/alpha-charon.yml:9: DATADOG_HOST: "{{ datadog_host_address }}"
group_vars/alpha-khronos.yml:21: -e DATADOG_HOST={{ datadog_host_address }}
group_vars/alpha-link.yml:11: -e DATADOG_HOST={{ datadog_host_address }}
group_vars/alpha-mavis.yml:16: -e DATADOG_HOST={{ datadog_host_address }}
group_vars/alpha-metis.yml:16: -e DATADOG_HOST={{ datadog_host_address }}
group_vars/alpha-navi.yml:11: -e DATADOG_HOST={{ datadog_host_address }}
group_vars/alpha-optimus.yml:16: -e DATADOG_HOST={{ datadog_host_address }}
group_vars/alpha-palantiri.yml:12: -e DATADOG_HOST={{ datadog_host_address }}
group_vars/alpha-shiva.yml:16: -e DATADOG_HOST={{ datadog_host_address }}
group_vars/alpha-workers.yml:17: -e DATADOG_HOST={{ datadog_host_address }}
roles/consul-services/tasks/main.yml:19: host_address: '{{ datadog_host_address }}'
Contributor
Author
There was a problem hiding this comment.
yep but THOSE don't every get referenced by anything, do they?
Contributor
Author
There was a problem hiding this comment.
regardless, the datadog.conf now uses 0.0.0.0 as it's bind IP, which is appropriate.
There was a problem hiding this comment.
so DATADOG_HOST is used in our code to connect to dd
Contributor
Author
There was a problem hiding this comment.
got it. well, it can be the ipv4 address of the main interface since we are now listening on 0.0.0.0, but it should definitely not be the IP address of the services host.
Contributor
|
That commit message though... Yikes... Haha |
und1sk0
changed the title
|
look ok to me, merge after you tested |
und1sk0
added a commit
that referenced
this pull request
Jan 18, 2016
ansiblize host-based datadog install
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…adog.yml" to deploy.